Allow creating token pools from an existing ERC1155 contract #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
force-pushed
the
pool-id
branch
2 times, most recently
from
b562df3
to
f29a911
Compare
Pools on ERC1155 are really just ranges of the token ID space. Going forward, all pools will be expressed with a startId and endId. This makes the service logic much less bound to the specific decisions made in the sample contract around partitioning it in chunks of exactly 2^128. The old poolId format such as "F1" or "N2" will still be parsed as expected, but will not be attached to any new pools. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
changed the title
Must specify the contract address, along with a startId and endId for a range of token IDs to form the pool. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
shorsher
approved these changes
May 31, 2023
| @@ -105,7 +105,7 @@ export class BlockchainConnectorService { | |||
| // Check if retry condition matches the err that's been hit | |||
| private matchesRetryCondition(err: any): boolean { | |||
| return ( | |||
| this.retryConfiguration.retryCondition != '' && | |||
| this.retryConfiguration.retryCondition !== '' && | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pools on ERC1155 are really just ranges of the token ID space. Going forward,
all pools will be expressed with a
startIdandendId. This makes the servicelogic much less bound to the specific decisions made in the sample contract
around partitioning it in chunks of exactly 2^128.
These
startIdandendIdparams can also be passed in onconfig(inaddition to
address) when creating a token pool, which will generate andreturn pool details immediately instead of expecting to call a
createmethod.The old poolId format such as "F1" or "N2" will still be parsed as expected,
but will not be attached to any new pools.
Fixes #104
Fixes #98
Breaking Change
There is a minor breaking change in that
info.typeIdon a token pool hasbeen replaced with
info.startIdfor consistency. Any applications that happento rely on this field will need to change to the new spelling.