Package lock v2 #126
Merged
Package lock v2 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annamcallister
requested review from
awrichar,
peterbroadhurst,
nguyer and
shorsher
as code owners
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
annamcallister
force-pushed
the
package-lock-v2
branch
from
2c6cf08
to
e826d16
Compare
awrichar
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm installin thesamples/soliditydirectory is taking longer than it should on supported node versions as it is having to convert the package lock from v1 to v2 format. The switch to v2 came with npm 7. npm 6 was supported for as long as node 14 was still supported, but node 14 is now EOL.I've also removed the truffle dependency as it is a large dependency which looks to be superseded by hardhat now.