Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the confirm option on the generated invoke APIs #1521

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

peterbroadhurst
Copy link
Contributor

  • The description was missing on the generated /invoke APIs
  • The description incorrectly referred to a "message" on the base /contracts/invoke API

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst requested a review from a team as a code owner June 7, 2024 20:30
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one question on the swagger that might be fine

@@ -5069,7 +5069,8 @@ paths:
description: Invokes a method on a smart contract. Performs a blockchain transaction.
operationId: postContractInvoke
parameters:
- description: When true the HTTP request blocks until the message is confirmed
- description: When true the HTTP request blocks until the blockchain transaction
is confirmed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why there is an end line here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @EnriqueL8 - I'm being slow. What's the problem with the string?

"When true the HTTP request blocks until the blockchain transaction is confirmed"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry - I see you're asking about the YAML formatting.

That's just a choice of the YAML serializer when the string exceeds a certain length, to use an indented newline to continue the string

@peterbroadhurst peterbroadhurst merged commit c2c5a95 into main Jun 17, 2024
14 checks passed
@peterbroadhurst peterbroadhurst deleted the confirm-docs branch June 17, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants