Use CLI to deploy test contract #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 303 303
Lines 17437 17437
=========================================
Hits 17437 17437 Continue to review full report at Codecov.
|
|
Note: this PR will fail until the CLI version |
awrichar
reviewed
Mar 10, 2022
| if [ "$TEST_SUITE" == "TestEthereumE2ESuite" ]; then | ||
| prefix='contract address: ' | ||
| output=$($CLI deploy $STACK_NAME ../data/simplestorage/simple_storage.json | grep address) | ||
| CONTRACT_ADDRESS=${output#"$prefix"} |
There was a problem hiding this comment.
Feels slightly fragile to parse this output, but if it works...
awrichar
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the E2E tests to use the new FireFly CLI feature to deploy contracts, rather than having deployment code baked in to the E2E tests directly.
Depends on hyperledger/firefly-cli#151