Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup some todos, imports #1223

Merged
merged 2 commits into from
Jun 25, 2024
Merged

chore: cleanup some todos, imports #1223

merged 2 commits into from
Jun 25, 2024

Conversation

patlo-iog
Copy link
Contributor

Description:

Cleanup todos and imports for merged and refactoring work.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Pat Losoponkul added 2 commits June 24, 2024 19:48
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io>
Signed-off-by: Pat Losoponkul <pat.losoponkul@iohk.io>
Copy link
Contributor

Integration Test Results

15 files  ±0  15 suites  ±0   2s ⏱️ ±0s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
46 runs  ±0  46 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6c373c7. ± Comparison against base commit 5398a75.

Copy link
Contributor

Unit Test Results

 96 files  ±0   96 suites  ±0   22m 37s ⏱️ -14s
826 tests ±0  818 ✅ ±0  8 💤 ±0  0 ❌ ±0 
833 runs  ±0  825 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 6c373c7. ± Comparison against base commit 5398a75.

@patlo-iog patlo-iog enabled auto-merge (squash) June 25, 2024 07:24
@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Jun 25, 2024
@patlo-iog patlo-iog merged commit 68626ed into main Jun 25, 2024
14 checks passed
@patlo-iog patlo-iog deleted the chore/cleanup-oid4vci branch June 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate Merge the main branch into a feature branch castor cloud-agent mercury pollux shared
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants