[refactor] #3682: Remove all direct dependencies on syn 1 #4357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This concludes the syn 2 migration saga, removing all mentions of it from the codebase. It also removes the
syn2
renaming of the new version, as we are no longer depending on two versions at the same time.We still have syn 1 as a transitive dependency on syn 1 though =(
I suggest reviewing the two commits separately, as the blank rename of
syn2
tosyn
is very noisyLinked issue
Closes #3682
Benefit
Less complexity due to use of multiple versions of the same library; only the shiny new API.
Checklist