Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective-C Support #200

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

Patrick-Kladek
Copy link

Description

Allows usage of this library from objc code.

Tasks

  • Mark classes & protocols with @objc
  • Change class to AnyObject in protocols to fix warnings
  • Apply recommended Xcode settings

Infos For Reviewer

Even though Issue #13 was closed I figured out that supporting objc was super easy.
I've started of 5.0 tag but can't create a PR from this commit and can't use 5.0.1 (master) as installation via cocoapods fails with following warning:

There is also an existing issue #188. How should we continue with this?

Bildschirmfoto 2021-10-20 um 13 35 09

@Patrick-Kladek Patrick-Kladek marked this pull request as ready for review October 20, 2021 09:39
@brendand
Copy link

Any chance 3 years later this could get merged into master?

@3lvis 3lvis changed the base branch from master to objc May 15, 2024 19:54
@3lvis
Copy link
Collaborator

3lvis commented May 15, 2024

Not sure why "Copy Pods Resources" was removed. Everything else seems ok.

@3lvis 3lvis merged commit c814932 into hyperoslo:objc May 15, 2024
@3lvis
Copy link
Collaborator

3lvis commented May 15, 2024

Merged into the objc branch for testing.

@3lvis
Copy link
Collaborator

3lvis commented May 15, 2024

@Patrick-Kladek thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants