-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compass 3.0.0 #33
Compass 3.0.0 #33
Conversation
@vadymmarkov, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zenangst, @jessearmand and @onmyway133 to be potential reviewers |
I agree with those ideas. I have removed Sugar as a dependency as well in my own fork. |
s.ios.source_files = 'Sources/{iOS,Shared}/**/*' | ||
s.osx.source_files = 'Sources/{Mac,Shared}/**/*' | ||
s.dependency 'Sugar' | ||
s.ios.source_files = 'Sources/**/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can reduce to just s.source_files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Well, seems like it's gonna be v3 because the last released is v2. We just had a wrong one in Podspec. |
🎸 🎶 🎶 |
@zenangst @RamonGilabert @onmyway133
We kinda like to break
Compass
from time to time, so it's a brand new breaking change 😄Compass.parse
completion closure in favour ofLocation
struct:So instead of:
We unwrap optional
Location
:The advantage of this approach is that
Compass.parse
is not async anymore, we get the needed result straight away and can handle the case whenurn
could not be parsed.Router
andRoutable
to support Mac by using type aliases.Location
struct. Makes it easier to add more properties in the future.String
methods fromSugar
and I feel like it's unnecessary to hold this dependency, especially thinking about Swift 3 where it's no longer actual. So... we don't useSugar
inCompass
anymore 😄