Feature/actual camera #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let view = UIView() | ||
| view.setTranslatesAutoresizingMaskIntoConstraints(false) | ||
| view.backgroundColor = self.configuration.backgroundColor | ||
| self.addSubview(view) |
There was a problem hiding this comment.
Better to add subviews in ViewDidLoad, so the views would not be added ocassionally, when you just want to access them.
| @@ -53,7 +53,7 @@ class ButtonPicker: UIButton { | |||
| // MARK: - Configuration | |||
|
|
|||
| func setupButton() { | |||
| backgroundColor = .whiteColor() | |||
| backgroundColor = UIColor.whiteColor() | |||
There was a problem hiding this comment.
What's wrong with .whiteColor() 😃
There was a problem hiding this comment.
Oh, probably I changed it to something else and then put white color again! 💃
|
@RamonGilabert Overall looks good for me. Nice work man! Is everything ready to merge? |
|
@vadymmarkov I'm changing 3 things right now and it's going to be ready to merge and use! :) |
| imageWrapper.firstImageView.image = array[0] as? UIImage | ||
| imageWrapper.secondImageView.image = array[1] as? UIImage | ||
| imageWrapper.firstImageView.image = array[1] as? UIImage | ||
| imageWrapper.secondImageView.image = array[0] as? UIImage |
There was a problem hiding this comment.
array.first can be used here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.