Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: permanent whistle #83

Merged
merged 8 commits into from
May 3, 2016
Merged

Feature: permanent whistle #83

merged 8 commits into from
May 3, 2016

Conversation

vadymmarkov
Copy link
Contributor

@RamonGilabert @zenangst @onmyway133

BREAKING CHANGE!!!

  1. duration property has been removed from Murmur.
  2. Whistle functions has new attribute action to show either temporary or permanent message:
let murmur = Murmur(title: "This is a small whistle...")

// Show and hide a message after delay
Whistle(murmur, action: .Show(1.5))
Whistle(murmur) // Show(1.5) is by default

// Present a permanent status bar message
Whistle(murmur, action: .Present)
  1. Whistle message could be hidden with a new Calm function:
// Hide a message
Calm()
  1. Action is renamed to WhisperAction because we got WhistleAction.

@zenangst zenangst merged commit 781f615 into master May 3, 2016
@zenangst zenangst deleted the feature/permanent-whistle branch May 3, 2016 12:27
@zenangst
Copy link
Contributor

zenangst commented May 3, 2016

0fpm0rs

@zenangst
Copy link
Contributor

zenangst commented May 3, 2016

@vadymmarkov you should probably do something about them tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants