Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DPC plugin for getting a bivariate histogram of the beam shifts #126

Closed
wants to merge 1 commit into from
Closed

Add DPC plugin for getting a bivariate histogram of the beam shifts #126

wants to merge 1 commit into from

Conversation

magnunor
Copy link
Contributor

@magnunor magnunor commented Apr 13, 2017 •
edited
Loading

  • Add unit test

vidartf
vidartf reviewed Apr 13, 2017
View reviewed changes
hyperspyui/plugins/dpc_makebivariatehistogram.py

def make_bivariate_histogram(self):
ui = self.ui
signal_wrapper_list = ui.select_x_signals(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check variable for None = cancel.

hyperspyui/plugins/dpc_makebivariatehistogram.py
spatial_std = 3
bins = 200

if (s0_flat.std() > s1_flat.std()):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should probably optimize by precalculating STD and mean, as it is used several times.

@magnunor magnunor mentioned this pull request Apr 17, 2017
Open
4 tasks
@magnunor magnunor closed this Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidartf vidartf vidartf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnunor @vidartf