Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivista xml2dict update #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pietsjoh
Copy link
Contributor

@pietsjoh pietsjoh commented Jun 12, 2023

Description of the change

The trivista filereader used its own version to convert an ET to a dict.
This PR switches this converter to utils.tools.XmlDict.

Progress of the PR

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.58%. Comparing base (576e8d9) to head (ab919f1).
Report is 332 commits behind head on main.

Files Patch % Lines
rsciio/trivista/_api.py 88.67% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   85.64%   85.58%   -0.07%     
==========================================
  Files          74       74              
  Lines        9817     9807      -10     
  Branches     2161     2156       -5     
==========================================
- Hits         8408     8393      -15     
- Misses        909      912       +3     
- Partials      500      502       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre added this to the v0.2 milestone Jul 8, 2023
@ericpre ericpre modified the milestones: v0.2, v0.3 Nov 8, 2023
@ericpre ericpre removed this from the v0.3 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants