Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding iterator interface and removing GetAll() method from attribute list #220

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

varkey98
Copy link
Contributor

@varkey98 varkey98 commented Nov 11, 2023

Adding an iterator interface on AttributeList so that the iterator can be queried without creating an additional slice.
Continuation of this pr: #217
ref: https://github.com/hypertrace/goagent/pull/217/files#r1385540220

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

sdk/span.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #220 (17f0db7) into main (de9ef45) will increase coverage by 0.61%.
Report is 1 commits behind head on main.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   58.94%   59.56%   +0.61%     
==========================================
  Files          55       55              
  Lines        2236     2248      +12     
==========================================
+ Hits         1318     1339      +21     
+ Misses        859      850       -9     
  Partials       59       59              
Files Coverage Δ
instrumentation/opentelemetry/span.go 86.81% <40.00%> (-3.51%) ⬇️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@varkey98
Copy link
Contributor Author

@ryanericson @tim-mwangi Please merge this pr, I cant merge since I dont have write access

@tim-mwangi tim-mwangi merged commit c2853ab into hypertrace:main Nov 13, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants