Fix netty connection keep alive #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanericson
reviewed
Jun 14, 2023
| @@ -103,6 +103,10 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise prm) { | |||
| span.setStatus(code >= 100 && code < 500 ? StatusCode.UNSET : StatusCode.ERROR); | |||
| } | |||
| if (msg instanceof LastHttpContent) { | |||
| ctx.channel() | |||
There was a problem hiding this comment.
Sounds like this could use some comment?
ryanericson
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client used
Connection: keep-aliveheader, only the first request was being captured. Subsequent requests were using the same context and so we were adding data in the same first span that was ended.We are setting the context as null when we end the span, so that whenever a new request comes, no matter, it will create a new context and a new span.
Tested this for both connection keep-alive and close.