move from error to warn #142
Conversation
| @@ -508,7 +508,7 @@ server: | |||
| type: pd-standard | |||
|
|
|||
| logging: | |||
| level: error | |||
| level: warn | |||
There was a problem hiding this comment.
it already is set to error in helm-values repo.
There was a problem hiding this comment.
We will adjust in helm-values repo as needed
There was a problem hiding this comment.
There was a problem hiding this comment.
what I meant was that we already have set the logging level to error. are there any specific warn logs we are interested in? there were too much logging by pinot.
There was a problem hiding this comment.
Laxman and mihir were of opinion we should have warn logs and fix any underlying issues
There was a problem hiding this comment.
I only suggested better to keep warn as the default.
If they are too noisy, we may need to investigate and fix or turn them off at package level in worst case.
| @@ -11,7 +11,7 @@ metadata: | |||
| heritage: {{ .Release.Service }} | |||
| data: | |||
| pinot-controller-log4j2.xml: |- | |||
| <Configuration> | |||
| <Configuration monitorInterval="30"> | |||
There was a problem hiding this comment.
same with this, we will be modifying in helm-values if overriden
| @@ -25,7 +25,7 @@ data: | |||
| <AppenderRef ref="console"/> | |||
| </Root> | |||
| <AsyncLogger name="org.reflections" level="error" additivity="false"/> | |||
| <AsyncLogger name="org.apache.pinot.broker.querylog.QueryLogger" level="info"/> | |||
| <Logger name="org.apache.pinot.broker.querylog.QueryLogger" level="info" additivity="false"/> | |||
There was a problem hiding this comment.
Logger need to have console appenderRef.
No description provided.