use pinot image for service manager in helm chart #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishansairam9
changed the title
ravisingal
reviewed
Apr 19, 2024
| @@ -0,0 +1,327 @@ | |||
| {{- if .Values.servicemanager.enabled }} | |||
There was a problem hiding this comment.
is this needed for single node setup?
There was a problem hiding this comment.
May be not, but I copied over the rules in case at some point we need to enable the metrics reporting to debug something. We can have it disabled by default
I missed having .Values.servicemanager.jmx.enabled in condition. Fixed it now
ravisingal
reviewed
Apr 19, 2024
ravisingal
reviewed
Apr 24, 2024
| "CONTROLLER", | ||
| "BROKER", | ||
| "SERVER", | ||
| {{- if .Values.servicemanager.minion.enabled }} |
There was a problem hiding this comment.
do we need minion on single node cluster?
There was a problem hiding this comment.
If we have only real time tables we don't need
ravisingal
reviewed
Apr 24, 2024
ravisingal
previously approved these changes
Apr 24, 2024
ravisingal
reviewed
Apr 24, 2024
Co-authored-by: Ravi Singal <62086374+ravisingal@users.noreply.github.com>
ravisingal
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.