chore: adding trino related env variables #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-dhingra
previously approved these changes
Oct 12, 2023
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
===========================================
Coverage 70.43% 70.43%
- Complexity 10 1047 +1037
===========================================
Files 96 96
Lines 4762 4762
Branches 549 549
===========================================
Hits 3354 3354
Misses 1188 1188
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
suresh-prakash
previously approved these changes
Oct 12, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
suresh-prakash
approved these changes
Oct 12, 2023
| @@ -90,6 +90,13 @@ spec: | |||
| name: {{ .Values.queryServiceConfig.data.postgresPasswordSecretName }} | |||
| key: {{ .Values.queryServiceConfig.data.postgresqlPasswordSecretKey }} | |||
| {{- end }} | |||
| {{- if eq .Values.queryServiceConfig.interactiveClientType "trino" }} | |||
| - name: {{ .Values.queryServiceConfig.data.postgresPasswordEnvVariable }} | |||
There was a problem hiding this comment.
Why postgresPasswordEnvVariable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR,