Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate Trino query error message to 2K #210

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

satish-mittal
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #210 (66bf069) into main (9e5f0e8) will increase coverage by 4.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #210      +/-   ##
============================================
+ Coverage     68.67%   72.70%   +4.02%     
- Complexity     1081     1091      +10     
============================================
  Files            93       96       +3     
  Lines          4747     4781      +34     
  Branches        550      551       +1     
============================================
+ Hits           3260     3476     +216     
+ Misses         1277     1081     -196     
- Partials        210      224      +14     
Flag Coverage Δ
integration 72.70% <0.00%> (?)
unit 68.66% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../query/service/trino/TrinoBasedRequestHandler.java 0.00% <0.00%> (ø)

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kotharironak
kotharironak previously approved these changes Oct 25, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@satish-mittal satish-mittal merged commit 40fc51e into main Oct 25, 2023
7 of 8 checks passed
@satish-mittal satish-mittal deleted the trino_exception_truncate branch October 25, 2023 11:38
@github-actions
Copy link

Unit Test Results

  40 files  ±0    40 suites  ±0   12s ⏱️ -1s
303 tests ±0  303 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 40fc51e. ± Comparison against base commit 9e5f0e8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants