chore: fix postgres query for array type column #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
============================================
+ Coverage 72.97% 73.28% +0.30%
- Complexity 1114 1120 +6
============================================
Files 96 96
Lines 4784 4783 -1
Branches 547 547
============================================
+ Hits 3491 3505 +14
+ Misses 1068 1053 -15
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aaron-steinfeld
previously approved these changes
Feb 1, 2024
added 2 commits
February 2, 2024 12:15
…gres_query_for_array_column
This comment has been minimized.
This comment has been minimized.
saxenakshitiz
commented
Feb 2, 2024
| @@ -95,7 +95,7 @@ public static void setup() throws Exception { | |||
| kafkaZk.start(); | |||
|
|
|||
| pinotServiceManager = | |||
| new GenericContainer<>(DockerImageName.parse("hypertrace/pinot-servicemanager:main")) | |||
| new GenericContainer<>(DockerImageName.parse("hypertrace/pinot-servicemanager:0.6.12")) | |||
There was a problem hiding this comment.
Filed a tracking ticket to make it work it with main version. Once fixed, will revert this change
aaron-steinfeld
approved these changes
Feb 2, 2024
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.