Addition of span count attribute #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 82.47% 82.47%
Complexity 419 419
=========================================
Files 37 37
Lines 1603 1603
Branches 168 168
=========================================
Hits 1322 1322
Misses 207 207
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| @@ -79,7 +79,8 @@ service.config = { | |||
| "EVENT.displaySpanName": "display_span_name", | |||
| "EVENT.errorCount": "error_count", | |||
| "EVENT.exceptionCount": "exception_count", | |||
| "EVENT.spaceIds": "space_ids" | |||
| "EVENT.spaceIds": "space_ids", | |||
| “EVENT.spanCount”: “span_count” | |||
There was a problem hiding this comment.
See comment about naming in config-bootstrapper PR
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Nov 12, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue : hypertrace/hypertrace-ui#1157