-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pure es6 import syntax #384
Merged
tyn1998
merged 8 commits into
hypertrons:master
from
tyn1998:refactor/pure-es6-import-syntax
Jul 7, 2022
Merged
refactor: pure es6 import syntax #384
tyn1998
merged 8 commits into
hypertrons:master
from
tyn1998:refactor/pure-es6-import-syntax
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed code is not important since we use absolute path when calling the crx-webpack-plugin.
menbotics
bot
added
the
kind/enhancement
Category issues or prs related to enhancement.
label
Jun 24, 2022
Since #352 adopted |
The workflow has been tested (after 10 times or so errors), see here. |
tyn1998
removed
the
kind/enhancement
Category issues or prs related to enhancement.
label
Jul 7, 2022
tyn1998
changed the title
[WIP] refactor: pure es6 import syntax
refactor: pure es6 import syntax
Jul 7, 2022
menbotics
bot
added
the
kind/enhancement
Category issues or prs related to enhancement.
label
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
Related issues:
Details
Convert all
require
toimport
.Except for conventional-changelog-action related scripts due to this.
Checklist
Others
Temporarily pause the work until #347 comes out.