Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pure es6 import syntax #384

Merged
merged 8 commits into from
Jul 7, 2022

Conversation

tyn1998
Copy link
Member

@tyn1998 tyn1998 commented Jun 24, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • ci
  • refactoring

Related issues:

Details

Convert all require to import.

Except for conventional-changelog-action related scripts due to this.

Checklist

Others

Temporarily pause the work until #347 comes out.

@menbotics menbotics bot added the kind/enhancement Category issues or prs related to enhancement. label Jun 24, 2022
@tyn1998 tyn1998 self-assigned this Jun 24, 2022
@tyn1998
Copy link
Member Author

tyn1998 commented Jul 7, 2022

Since #352 adopted require syntax, now I will refactor to convert it to pure es6 modules and test the workflow in https://github.com/tyn1998/workflows-for-hypercrx.

@tyn1998
Copy link
Member Author

tyn1998 commented Jul 7, 2022

The workflow has been tested (after 10 times or so errors), see here.

@tyn1998 tyn1998 marked this pull request as ready for review July 7, 2022 08:20
@tyn1998 tyn1998 removed the kind/enhancement Category issues or prs related to enhancement. label Jul 7, 2022
@tyn1998 tyn1998 changed the title [WIP] refactor: pure es6 import syntax refactor: pure es6 import syntax Jul 7, 2022
@menbotics menbotics bot added the kind/enhancement Category issues or prs related to enhancement. label Jul 7, 2022
@tyn1998 tyn1998 merged commit a57e3d7 into hypertrons:master Jul 7, 2022
@tyn1998
Copy link
Member Author

tyn1998 commented Jul 7, 2022

Confirmed again, deploy is OK:

image

@tyn1998 tyn1998 deleted the refactor/pure-es6-import-syntax branch July 22, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] embrace pure es6 import syntax
1 participant