V3 java-SDK - ppplmer-96596 update query parameters - Part C #136
Conversation
…method for currency query parameter
… listStatusTransition methods
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| private Type type; | |||
| private Status status; | |||
| private Status transition; | |||
There was a problem hiding this comment.
Bank Account transition has only two possible states:
- DE_ACTIVATED
- ACTIVATED
Please create a separate enum to fix this.
There was a problem hiding this comment.
Per the documentation possible status' are as given below.
ACTIVATED
VERIFIED
INVALID
DE_ACTIVATED
and for transitions they are:
ACTIVATED
VERIFIED
INVALID
DE_ACTIVATED
They are declared in the following lines as enumerations already. Status is used for transition too.
public static enum Status {ACTIVATED, VERIFIED, INVALID, DE_ACTIVATED}
Let me know if anymore change is still required.
There was a problem hiding this comment.
I'm referring to this link: https://docs.hyperwallet.com/content/api/v3/resources/status-transitions/bank-accounts-create for Bank Account Status transition. Please let me know if I have to refer to another link.
There was a problem hiding this comment.
This is an inconsistency. A new ticket has to be created for this to update the document. However, addition of Verified and Invalid in the query will not break the functionality. Please approve the request now as I am going by the document https://docs.hyperwallet.com/content/api/v4/resources/status-transitions/bank-accounts-retrieve for now.
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| private HyperwalletBankAccount.Type type; | |||
| private HyperwalletBankAccount.Status status; | |||
| private HyperwalletBankAccount.Status transition; | |||
There was a problem hiding this comment.
Same comment as above.
There was a problem hiding this comment.
Same comment as given above.
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| private Type type; | |||
| private Status status; | |||
| private Status transition; | |||
There was a problem hiding this comment.
Same comment as above.
There was a problem hiding this comment.
Same comment as given above.
| @@ -19,6 +19,8 @@ | |||
| private HyperwalletTransferMethod.Type type; | |||
| private String token; | |||
| private HyperwalletTransferMethod.Status status; | |||
| private HyperwalletTransferMethod.Status transition; | |||
There was a problem hiding this comment.
The comment with respect to transition is generic. Pls fix in all the places.
There was a problem hiding this comment.
These were not refactored to keep it in accordance with V4 and the existing approach taken to refer to HyperwalletTransferMethod class for other fields like type and status. Changing the approach will call for changes in V4 and also other methods where HyperwalletPaperCheck is called.
| @@ -10,14 +10,13 @@ protected HyperwalletPayment createBaseModel() { | |||
| HyperwalletPayment payment = new HyperwalletPayment(); | |||
| payment | |||
| .status("COMPLETED") | |||
| .transition("COMPLETED") | |||
There was a problem hiding this comment.
CANCELLED is the only available transition for HyperwalletPayment.
There was a problem hiding this comment.
Following are the status transitions allowed for HyperwalletPayment. 'COMPLETED' is one of them and 'CANCELLED' is not one of them. Details are per https://docs.hyperwallet.com/content/api/v3/resources/status-transitions/list. Please let me know if there is any error in my statement.
CREATED
SCHEDULED
PENDING_ACCOUNT_ACTIVATION
PENDING_ID_VERIFICATION
PENDING_TAX_VERIFICATION
PENDING_TRANSFER_METHOD_ACTION
PENDING_TRANSACTION_VERIFICATION
IN_PROGRESS
UNCLAIMED
COMPLETED
FAILED
RECALLED
RETURNED
EXPIRED
src/test/java/com/hyperwallet/clientsdk/model/HyperwalletPrepaidCardTest.java
Outdated
Show resolved
Hide resolved
Made query parameter changes for the following objects and their list methods. Please review and approve.