Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRUNEONE-4575 Update error handling V3 #170

Merged

Conversation

skoong
Copy link
Collaborator

@skoong skoong commented Mar 4, 2022

Changes in this pull request:

  • Hardening error response handler to return the correct response status and message from the server when there is an exception converting
  • Update decryptErrorResponse to check for content-type before attempting to decrypt (because it's possible that the response is not encrypted)

Testing:
GET/PUT/POST
Successful Response
Error Response

  • Empty Body
  • Hyperwallet Error Response - Content-Type - application/json
  • Hyperwallet Encrypted Error Response - Content-Type - application/jose+json
  • Unrecognized Error Response - Content-Type - text/html
Tests run: 1665, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 57.994 sec - in TestSuite

Results :

Tests run: 1665, Failures: 0, Errors: 0, Skipped: 0

@skoong skoong merged commit 6004dd9 into support/SDK-V3 Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/DTRUNEONE-4575-Updating-Error-Handling-V3 branch March 10, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants