Merge pull request #63 from hyperwallet/V4-unable-to-list-webhooks

V4 unable to list webhooks

Author: wmews-hw

package-lock.json

@@ -1741,7 +1741,9 @@ export default class Hyperwallet {
      * @param {api-callback} callback - The callback for this call
      */
     listWebhookNotifications(options, callback) {
-        const LIST_WEBHOOK_NOTIFICATIONS_FILTERS = ["programToken", "type"];
+        const LIST_WEBHOOK_NOTIFICATIONS_FILTERS = ["programToken", "createdBefore", "createdAfter",
+            "type", "sortBy", "limit"];
+
         if (options && !this.isValidFilter(options, LIST_WEBHOOK_NOTIFICATIONS_FILTERS)) {
             throw new Error("Invalid Filter. Expected - ".concat(LIST_WEBHOOK_NOTIFICATIONS_FILTERS));
         }
@@ -1987,12 +1989,12 @@ export default class Hyperwallet {
     /**
      * Validate the options filter
      *
-     * @param {Object} inputFilters - The query parameters in the URI
+     * @param {Object} options - The query parameters in the URI
      * @param {Object} listFilters - Defined list of filters for a business object
      */
 
-    isValidFilter(inputFilters, listFilters) {
-        return Object.keys(inputFilters).every(elem => listFilters.includes(elem));
+    isValidFilter(options, listFilters) {
+        return Object.keys(options).every(elem => listFilters.includes(elem));
     }
 
     //--------------------------------------

src/Hyperwallet.js

@@ -247,9 +247,11 @@ describe("Hyperwallet", () => {
         /** @test {Hyperwallet#listUsers} */
         it("should do get call with options", () => {
             const callback = () => null;
-            client.listUsers({ clientUserId: "test-client-user-id", status: "test-status" }, callback);
+            client.listUsers({ clientUserId: "test-client-user-id", email: "test-email", programToken: "test-programToken",
+                status: "test-status", verificationStatus: "test-verificationStatus" }, callback);
             apiClientSpy.should.have.been.calledOnce();
-            apiClientSpy.should.have.been.calledWith("users", { clientUserId: "test-client-user-id", status: "test-status" });
+            apiClientSpy.should.have.been.calledWith("users", { clientUserId: "test-client-user-id", email: "test-email",
+                programToken: "test-programToken", status: "test-status", verificationStatus: "test-verificationStatus" });
         });
 
         /** @test {Hyperwallet#listUsers} */
@@ -4061,7 +4063,8 @@ describe("Hyperwallet", () => {
         /** @test {Hyperwallet#listWebhookNotifications} */
         it("should throw error for invalid filter", () => {
             const callback = () => null;
-            expect(() => client.listWebhookNotifications({ test: "value" }, callback)).to.throw("Invalid Filter. Expected - programToken,type");
+            expect(() => client.listWebhookNotifications({ test: "value" }, callback)).to.throw(
+                "Invalid Filter. Expected - programToken,createdBefore,createdAfter,type,sortBy,limit");
         });
 
         /** @test {Hyperwallet#listWebhookNotifications} */