-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use HTTPS protocol in URLs #379
base: master
Are you sure you want to change the base?
Conversation
Hi, http(s) is already supported, see: https://helm-s3.hypnoglow.io/docs/advanced-features/#serving-charts-via-http What is the motivation of the proposed change? |
Hi, we are using the relative param as an alternative option for now. |
I see the effect, but I don't understand the need yet.
Could you please elaborate on this and provide more details on your use case? I'm asking because some time ago we had a similar discussion. There was a proposal similar to your change request. In the end we concluded that |
The relative path does not cause problems if interact with this index only through helm. But when using a relative path, the index file loses information about the location of the chart. So, this makes it impossible to use the index file outside the directory with the chart files. Therefore, it is necessary that the index file has absolute paths + does not differ from the structure created by the official I expect that this PR will allow to use this plugin for manage charts and automatically rebuild index and in same time will allow users to download charts via https while keeping the index structure as it is when generating through the helm itself. |
This change allows clients to download Helm charts over HTTPS while retaining the ability to upload Helm charts via S3.