Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use HTTPS protocol in URLs #379

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

sonjek
Copy link

@sonjek sonjek commented Mar 12, 2024

This change allows clients to download Helm charts over HTTPS while retaining the ability to upload Helm charts via S3.

@hypnoglow
Copy link
Owner

Hi,

http(s) is already supported, see: https://helm-s3.hypnoglow.io/docs/advanced-features/#serving-charts-via-http

What is the motivation of the proposed change?

@sonjek
Copy link
Author

sonjek commented Mar 13, 2024

Hi, we are using the relative param as an alternative option for now.
But relative paths are not convenient when parsing the file index.
Therefore, this change allows to write an absolute path with the https protocol (like helm repo index).

@hypnoglow
Copy link
Owner

@sonjek

Therefore, this change allows to write an absolute path with the https protocol (like helm repo index).

I see the effect, but I don't understand the need yet.

But relative paths are not convenient when parsing the file index.

Could you please elaborate on this and provide more details on your use case? I'm asking because some time ago we had a similar discussion. There was a proposal similar to your change request. In the end we concluded that --relative option solves the problem and we don't need anything more complex.

@sonjek
Copy link
Author

sonjek commented Mar 13, 2024

The relative path does not cause problems if interact with this index only through helm.

But when using a relative path, the index file loses information about the location of the chart.
Therefore, the relative path breaks the essence of repository metadata logic. The file does not contain all the necessary information.

So, this makes it impossible to use the index file outside the directory with the chart files.
The index file saved locally or on the server does not allow to find out where the chart files are located.
If you need to download and parse the index file, you need to additionally set helm files path.

Therefore, it is necessary that the index file has absolute paths + does not differ from the structure created by the official helm repo index.

I expect that this PR will allow to use this plugin for manage charts and automatically rebuild index and in same time will allow users to download charts via https while keeping the index structure as it is when generating through the helm itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants