Bump sqlalchemy from 1.4.48 to 2.0.16 #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 1.4.48 to 2.0.16. - [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases) - [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/main/CHANGES.rst) - [Commits](https://github.com/sqlalchemy/sqlalchemy/commits) --- updated-dependencies: - dependency-name: sqlalchemy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
jon-betts
force-pushed
the
dependabot/pip/sqlalchemy-2.0.16
branch
from
9520e6c
to
cc9e604
Compare
jon-betts
reviewed
Jun 14, 2023
| session.transaction._connections # pylint:disable=protected-access | ||
| ) | ||
| if len(connections) > 1: | ||
| LOG.warning("closing an unclosed DB session") |
There was a problem hiding this comment.
The 'transaction' attribute isn't there in the new version. I'm not exactly what the hint we are in this situation would be now. We don't need to actually check this, as it's only for the warning, so I've removed it.
marcospri
approved these changes
Jun 14, 2023
seanh
added a commit
that referenced
this pull request
Jun 22, 2023
The upgrade to SQLAlchemy (#689) has broken `make dev` in Checkmate: the app no longer starts up at all in dev: $ make dev web (stderr) | [...] [577266] [ERROR] Exception in worker process web (stderr) | Traceback (most recent call last): ... web (stderr) | File ".../checkmate/checkmate/db.py", line 87, in _stamp_db web (stderr) | engine.execute("select 1 from alembic_version") web (stderr) | AttributeError: 'Engine' object has no attribute 'execute' There's no longer an `engine.execute()` method in SQLAlchemy 2. Instead you have to call `engine.connect()` to get a connection object and then call `connection.execute()`. See: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#implicit-and-connectionless-execution-bound-metadata-removed In addition you can't just pass a string of SQL to `connection.execute()`, you have to use `text()`.
seanh
added a commit
that referenced
this pull request
Jun 22, 2023
The upgrade to SQLAlchemy (#689) has broken `make dev` in Checkmate: the app no longer starts up at all in dev: $ make dev web (stderr) | [...] [577266] [ERROR] Exception in worker process web (stderr) | Traceback (most recent call last): ... web (stderr) | File ".../checkmate/checkmate/db.py", line 87, in _stamp_db web (stderr) | engine.execute("select 1 from alembic_version") web (stderr) | AttributeError: 'Engine' object has no attribute 'execute' There's no longer an `engine.execute()` method in SQLAlchemy 2. Instead you have to call `engine.connect()` to get a connection object and then call `connection.execute()`. See: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#implicit-and-connectionless-execution-bound-metadata-removed In addition you can't just pass a string of SQL to `connection.execute()`, you have to use `text()`.
seanh
added a commit
that referenced
this pull request
Jun 26, 2023
The upgrade to SQLAlchemy (#689) has broken `make dev` in Checkmate: the app no longer starts up at all in dev: $ make dev web (stderr) | [...] [577266] [ERROR] Exception in worker process web (stderr) | Traceback (most recent call last): ... web (stderr) | File ".../checkmate/checkmate/db.py", line 87, in _stamp_db web (stderr) | engine.execute("select 1 from alembic_version") web (stderr) | AttributeError: 'Engine' object has no attribute 'execute' There's no longer an `engine.execute()` method in SQLAlchemy 2. Instead you have to call `engine.connect()` to get a connection object and then call `connection.execute()`. See: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#implicit-and-connectionless-execution-bound-metadata-removed In addition you can't just pass a string of SQL to `connection.execute()`, you have to use `text()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sqlalchemy from 1.4.48 to 2.0.16.
Release notes
Sourced from sqlalchemy's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)