Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct links to Page Notes not working #129

Closed
robertknight opened this issue Sep 23, 2016 · 2 comments
Closed

Direct links to Page Notes not working #129

robertknight opened this issue Sep 23, 2016 · 2 comments

Comments

@robertknight
Copy link
Member

robertknight commented Sep 23, 2016 •
edited
Loading

Steps to reproduce

  1. On master (Git commit >= f588f1e) create a Page Note on http://localhost:5000/docs/help
  2. Go to http://localhost:5000/docs/help#annotations:<ID>

Expected behaviour

The client should select and display the Page Note

Actual behaviour

The client indicates that there is a selection but the button reads "Show all annotations" instead of "Show all notes" and does not display the page note

Notes

This broke after #116

Selecting the tab containing a direct-linked annotation currently happens when the annotation is anchored (in response to the ANNOTATIONS_SYNCED) event. Page Notes do not get anchored. We could actually select the appropriate tab at the point where the annotation is loaded into the app instead - although we may later need to change that selection if an annotation becomes an orphan.
@robertknight robertknight mentioned this issue Sep 23, 2016
Closed
@robertknight
Copy link
Member Author

Fix direct links to Page Notes

@robertknight robertknight mentioned this issue Sep 26, 2016
Merged
robertknight added a commit that referenced this issue Sep 26, 2016
@robertknight
Fix scrolling to direct-linked annotations
d61ba10 
The FrameSync service introduced in 55093eb emitted an
ANNOTATIONS_SYNCED event which unintentionally had a different type for
the `tags` argument than the previous code (`string[]`, instead of
`Array<{tag:string}>`)

This commit updates the code in WidgetController to expect `tags`
to be of type `string[]`.

Fixes #129
@robertknight
Copy link
Member Author

The problem in master extends beyond this. Scroll to and focusing direct-linked annotations is also broken.

@robertknight robertknight mentioned this issue Sep 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertknight