Rename the "$$tag" annotation property and remove Object.assign() hacks #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. However, lot's of code change here and some historical context, it should probably be checked by someone how knows what else to expect from this change |
|
Needs a rebase. |
|
Let's get this rebased so we can get it merged? |
robertknight
force-pushed
the
rename-local-tag
branch
from
b555bb6
to
f580c57
Compare
This property previously had a "$$" prefix instead of the conventional single "$" prefix for local-only properties of annotations for historical reasons.
The `$tag` property is now enumerable.
robertknight
force-pushed
the
rename-local-tag
branch
from
f580c57
to
52d045e
Compare
|
LGTM. Tested it out on http://localhost:5000/docs/help by creating, editing, replying to and deleting an annotation and seems to work fine. |
sheetaluk
pushed a commit
that referenced
this pull request
Oct 24, 2016
This property previously had a "$$" prefix instead of the conventional single "$" prefix for local-only properties of annotations for historical reasons. This is a followup PR to: #126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "$$tag" annotation property which stores the local ID of annotations had a "$$" prefix for historical reasons and had to be explicitly copied when shallow-cloning annotation objects with
Object.assign()because it was non-enumerable.Following #116 , this can now be cleaned up within the sidebar app. This PR renames
$$tagto$tagto match the other local-only annotation properties and removes theObject.assign()hacks.