Fix new replies being moved to the newly focused group #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only new top level annotations should be moved to the new group when switching groups. Fixes hypothesis/h#3559
seanh
force-pushed
the
do-not-move-new-replies-on-group-change
branch
from
d8f3c7b
to
f40b892
Compare
|
Rebased |
|
Hmm, I still seem to be able to reproduce the issue on this branch |
|
After some more investigation it turns out that the issue is now fixed if you have the selection-tabs feature enabled, and the reply's group is no longer changed when switching groups. However, if you do not have the selection-tabs feature enabled, then the reply still appears. |
Previously the `group` and `permissions` properties of new replies were set _after_ creating the reply with `createAnnotation()`. This meant that the new reply did not have the correct group and permissions when it was filtered for the first time by the `buildThread()` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #8
Only new top level annotations should be moved to the new group when
switching groups.
Fixes hypothesis/h#3559