Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update the copyright year #105

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Don't update the copyright year #105

merged 1 commit into from
Jan 11, 2023

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Jan 10, 2023

Don't update the copyright year in the LICENSE file to the current year. Otherwise every year the cookiecutter is going to want to update the LICENSE file in every project.

If we actually want to automate updating copyright years one day we can do that: just write a script the reads cookiecutter.json, changes __copyright_year, writes it back, and runs make template. Commando or another tool could be used to run such a script on every project and send PRs. But I don't think we need to update these.

Anyway, this PR just prevents make template from making this change by itself, which I think is clearly undesirable

Don't update the copyright year in the `LICENSE` file to the current
year. Otherwise every year the cookiecutter is going to want to update
the `LICENSE` file in every project.
@seanh seanh changed the title dont update year Don't update the copyright year Jan 10, 2023
@@ -18,6 +18,7 @@
"__docker_namespace": "{{ cookiecutter.github_owner }}",
"__docker_network": "{{ cookiecutter.package_name }}_default",
"__github_url": "https://github.com/{{ cookiecutter.github_owner }}/{{ cookiecutter.slug }}",
"__copyright_year": "{% now 'utc', '%Y' %}",
Copy link
Contributor Author

@seanh seanh Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to the current year when generating a new project. Thereafter it'll use the __copyright_year in the project's cookiecutter.json file.

The __ is so that cookiecutter doesn't interactively ask the user for the copyright year when creating a new project. It has to be __ not just _ to enable Jinja2 in the value. If you wanted to specify a different copyright year for a new project for some reason you could pass it as a command line argument: cookiecutter gh:hypothesis/cookiecutters ... __copyright_year=1981

Copy link
Contributor

@jon-betts jon-betts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the correct behavior. As I understand it we don't / shouldn't want to update the copyright date ever really.

This is because the date provides the starting point of copyright protection (+50 / 70 years). If you "update" the value, you strip yourself of historical protection. This means should someone else have copied the work in the mean time, and has a prior date to us, it will appear as if we stole the work rather than the other way around.

I believe you can include the start date and an update date in a copyright statement (c) 2001-2023 when the work has been altered. The correct time to do this would probably be on commit, but that would be horrible.

Long story short, I think this is much better.

seanh added a commit to hypothesis/tox-envfile that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/pip-sync-faster that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
@seanh seanh merged commit ca6f8cf into main Jan 11, 2023
@seanh seanh deleted the dont-update-year branch January 11, 2023 14:36
seanh added a commit to hypothesis/test-pypackage that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/tox-recreate that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-api that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/test-pyapp that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/test-pyramid-app that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-periodic that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/commando that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/gha-token that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/data-tasks that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/testpilot that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/pyramid-sanity that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/report that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/tox-envfile that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/pip-sync-faster that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/test-pypackage that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/tox-recreate that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-api that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/test-pyapp that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/test-pyramid-app that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-periodic that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/commando that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/gha-token that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-vialib that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-matchers that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/tox-faster that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/gh-pr-upsert that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-assets that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/pyramid-googleauth that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/h-pyramid-sentry that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/testpilot that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/pyramid-sanity that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/checkmatelib that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/report that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
seanh added a commit to hypothesis/data-tasks that referenced this pull request Jan 11, 2023
This is needed to prevent the cookiecutter from updating the copyright year in
the LICENSE file to the current year every new year. See:

hypothesis/cookiecutters#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants