-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update the copyright year #105
Conversation
Don't update the copyright year in the `LICENSE` file to the current year. Otherwise every year the cookiecutter is going to want to update the `LICENSE` file in every project.
@@ -18,6 +18,7 @@ | |||
"__docker_namespace": "{{ cookiecutter.github_owner }}", | |||
"__docker_network": "{{ cookiecutter.package_name }}_default", | |||
"__github_url": "https://github.com/{{ cookiecutter.github_owner }}/{{ cookiecutter.slug }}", | |||
"__copyright_year": "{% now 'utc', '%Y' %}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to the current year when generating a new project. Thereafter it'll use the __copyright_year
in the project's cookiecutter.json
file.
The __
is so that cookiecutter doesn't interactively ask the user for the copyright year when creating a new project. It has to be __
not just _
to enable Jinja2 in the value. If you wanted to specify a different copyright year for a new project for some reason you could pass it as a command line argument: cookiecutter gh:hypothesis/cookiecutters ... __copyright_year=1981
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the correct behavior. As I understand it we don't / shouldn't want to update the copyright date ever really.
This is because the date provides the starting point of copyright protection (+50 / 70 years). If you "update" the value, you strip yourself of historical protection. This means should someone else have copied the work in the mean time, and has a prior date to us, it will appear as if we stole the work rather than the other way around.
I believe you can include the start date and an update date in a copyright statement (c) 2001-2023 when the work has been altered. The correct time to do this would probably be on commit, but that would be horrible.
Long story short, I think this is much better.
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
This is needed to prevent the cookiecutter from updating the copyright year in the LICENSE file to the current year every new year. See: hypothesis/cookiecutters#105
Don't update the copyright year in the
LICENSE
file to the current year. Otherwise every year the cookiecutter is going to want to update theLICENSE
file in every project.If we actually want to automate updating copyright years one day we can do that: just write a script the reads
cookiecutter.json
, changes__copyright_year
, writes it back, and runsmake template
. Commando or another tool could be used to run such a script on every project and send PRs. But I don't think we need to update these.Anyway, this PR just prevents
make template
from making this change by itself, which I think is clearly undesirable