Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill attribute to pointer-up and pointer-down icons #1586

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Jun 19, 2024

Add a missing fill="currentColor" attribute to PointerUp and PointerDown colors. I added it to the svg files, and then regenerated icons.

Notice the color difference of the two bottom-left icons compored to the rest.

Before:

Captura desde 2024-06-19 09-04-09

After:

Captura desde 2024-06-19 09-04-15

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b38f90b) to head (53c1f32).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1586   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1041      1041           
  Branches       397       397           
=========================================
  Hits          1041      1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acelaya acelaya merged commit ea267fe into main Jun 19, 2024
4 checks passed
@acelaya acelaya deleted the icons-current-color branch June 19, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants