Remove deprecated elements for next major release #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
===========================================
+ Coverage 99.90% 100.00% +0.09%
===========================================
Files 62 61 -1
Lines 1071 1036 -35
Branches 409 398 -11
===========================================
- Hits 1070 1036 -34
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
acelaya
commented
Jul 23, 2024
Comment on lines
-336
to
-338
| if (multiple && !Array.isArray(value)) { | ||
| throw new Error('When `multiple` is true, the value must be an array'); | ||
| } |
There was a problem hiding this comment.
There's no need to check this anymore, as we enforce it via static types.
Selectallows single-item values and hardcodesmultiple: false.MultiSelectallows array values and hardcodesmultiple: true.
|
I'll go ahead and merge this, then release v8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1306
Closes #1621
This PR removes the next deprecated symbols before releasing next major version:
SelectNext, which is replaced bySelectorMultiSelect.useElementShouldClose, which is replaced byusePopoverShouldClose.