Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual testing instructions #4

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Jul 25, 2022

Add instructions to HACKING.md for how to test your local development version of this tox plugin in tox.

I don't think it makes sense to try to make this any easier (for example by trying to wrap the whole thing in a convenient make command): we only maintain a few tox plugins and they're all really simple ones that hopefully won't require much ongoing development. Maybe we can try just living with manual instructions for this in HACKING.md for now.

Once we merge this I'll add the same to the tox.ini files of tox-faster and tox-envfile. We could add this to the pypackage cookiecutter but it only applies to tox plugins so we'd have to add a tox_plugin boolean setting to cookiecutter.json (similar to other boolean settings like console_script). Might not be worth adding this to the cookiecutter since it only applies to tox plugins?

@seanh seanh force-pushed the add-manual-testing-instructions branch from 6cda82e to 06e30e3 Compare July 28, 2022 16:47
@seanh seanh marked this pull request as ready for review July 28, 2022 16:51
@seanh seanh mentioned this pull request Jul 31, 2022
venv:

```terminal
make --directory "/tmp/cookiecutter-pypackage-test" sure
Copy link
Member

@marcospri marcospri Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is make sure missing a sure: python (the python bit)

I had to call bin/make_python manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks like a bug in the cookiecutter. Opened an issue: hypothesis/cookiecutters#48

Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is very useful specially in repos were we don't work on very often.

There's a missing dependency on make sure definition but that probably needs to be fixed via the cookiecutter + PRs to re-apply it.

@seanh seanh merged commit 8701c72 into main Aug 8, 2022
@seanh seanh deleted the add-manual-testing-instructions branch August 8, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants