Replace hipcc option --amdgpu-target with --offload-arch
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it back compatible? |
|
Tested with rocm 5.2, which is the minimum we support now |
Do we state this somewhere? In the manual? |
|
I didn't find it either. We should add to the manual/Wiki... Right now, 5.2 is what we test with machine-tioga and hypre doesn't compile with versions older than 5.2 (I tried). I don't think we should support rocm older than 5.2 |
Agreed. I used to test 5.1 or even 5.0. Not sure if it's still worth it. |
liruipeng
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1026.
Tested with rocm 5.2 and newer (tioga)