Update hypre_ParVectorPrintIJ
#1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/parcsr_mv/par_vector.c
Outdated
| for (j = 0; j < local_size; j++) | ||
| { | ||
| hypre_fprintf(file, "%b %.14e\n", | ||
| (HYPRE_BigInt) j + base_j, |
There was a problem hiding this comment.
Does this need to be BigInt? I thought local sizes were always int?
There was a problem hiding this comment.
These are global indices, so need to be BigInt
There was a problem hiding this comment.
@victorapm is base_j supposed to be BigInt then? Index j only goes from 0 to local_size, so it seems not a BigInt to me. base_j is passed as argument as HYPRE_Int.
There was a problem hiding this comment.
Yes, let me update this, thanks for catching!
ulrikeyang
approved these changes
Dec 20, 2023
|
Yes, I have a separate PR for that :) |
geraldc-unm
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Add multi-component vector support to hypre_ParVectorPrintIJ * Make hypre_ParVectorPrintIJ conforming with HYPRE_IJVectorPrint * Make hypre_ParVectorReadIJ conforming with HYPRE_IJVectorRead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-component vector support to
hypre_ParVectorPrintIJThis feature is important for GEOS