Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coarsen type #1080

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Fix coarsen type #1080

merged 7 commits into from
Mar 11, 2024

Conversation

liruipeng
Copy link
Contributor

@liruipeng liruipeng commented Mar 6, 2024

This PR removes a potential coarsen_type change in AMG setup on GPUs. The CPU code remains the same.

  • tux
  • lassen
  • sunspot

Copy link
Contributor

@ulrikeyang ulrikeyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@liruipeng
Copy link
Contributor Author

liruipeng commented Mar 7, 2024

Interestingly, we got some "errors" on GPUs with this change, see below. So this means we actually hit that line of changing coarsen_type. Should we go ahead to change the .saved files?

(254) - Final Relative Residual Norm = 1.807958e-09
(254) + Final Relative Residual Norm = 1.802890e-09      (err 5.07e-12)

(262) - Final Relative Residual Norm = 1.807958e-09
(262) + Final Relative Residual Norm = 1.802890e-09      (err 5.07e-12)

(286) - Final Relative Residual Norm = 4.616163e-09
(286) + Final Relative Residual Norm = 7.693914e-09      (err 3.08e-09)

(294) - Final Relative Residual Norm = 7.457096e-09
(294) + Final Relative Residual Norm = 8.665192e-09      (err 1.21e-09)

@rfalgout
Copy link
Contributor

rfalgout commented Mar 7, 2024

Interestingly, we got some "errors" on GPUs with this change, see below. So this means we actually hit that line of changing coarsen_type. Should we go ahead to change the .saved files?

Just to document what we just talked about, yes I think you should change the .saved files. Thanks!

@liruipeng liruipeng merged commit 48052f6 into master Mar 11, 2024
@liruipeng liruipeng deleted the fix_coarsen_type branch March 11, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants