Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counterpart for fakefullscreen #1817

Closed
JustSimplyKyle opened this issue Mar 18, 2023 · 11 comments · Fixed by #4720
Closed

Counterpart for fakefullscreen #1817

JustSimplyKyle opened this issue Mar 18, 2023 · 11 comments · Fixed by #4720
Labels
enhancement New feature or request

Comments

@JustSimplyKyle
Copy link
Contributor

JustSimplyKyle commented Mar 18, 2023

FakeFullscreen would currently send the fullscreen state but not alter the geometry.
What I want is I want to alter the geometry to be fullscreened, but not the state.
The main usage for this would be fullscreening a wayland chromium without losing the title bar

tl;dr fullscreen the app without telling it

@vaxerski
Copy link
Member

vaxerski commented Apr 8, 2023

No, it's not. I have a kjhillion other things to work on. If you really want it that bad, you can always make a pr.

If you can't / don't want to, you can like the original post instead of posting useless comments

@GrabbenD
Copy link

Thanks a lot for implementing this @vaxerski!

@JustSimplyKyle

# Exclusive fullscreen with mainMod + P
bind = $mainMod, F, fullscreen, 0

# Windowed fullscreen with mainMod + SHIFT + P
bind = $mainMod SHIFT, F, fullscreen, 1

@vaxerski
Copy link
Member

wat

@GrabbenD
Copy link

@vaxerski I was skimming through the documentation and noticed fullscreen, 0 (takes your entire screen) and fullscreen, 1 (keeps gaps and bar(s)). Mode 1 is exactly what I was looking for in #1923 and I suppose that's what @JustSimplyKyle requested in this PR:

The main usage for this would be fullscreening a wayland chromium without losing the title bar

Sounds like this PR is resolved unless I've misunderstood something :)

@vaxerski
Copy link
Member

you have misunderstood it

@GrabbenD
Copy link

GrabbenD commented Apr 14, 2023

I suppose the idea is to just keep bars but not gaps in that case (e.g. fullscreen, 2)?

@vaxerski
Copy link
Member

pleease stop trashing this conversation

@fraschm1998
Copy link

@vaxerski I was skimming through the documentation and noticed fullscreen, 0 (takes your entire screen) and fullscreen, 1 (keeps gaps and bar(s)). Mode 1 is exactly what I was looking for in #1923 and I suppose that's what @JustSimplyKyle requested in this PR:

The main usage for this would be fullscreening a wayland chromium without losing the title bar

Sounds like this PR is resolved unless I've misunderstood something :)

I think he's referring to something like the dwm patch https://dwm.suckless.org/patches/fakefullscreen/

@vaxerski
Copy link
Member

vaxerski commented Sep 19, 2023

I don't know on which forum post this message got linked but cherry-picking one message of mine when I was probably having a shit day half a year ago is also weird, imo.

Edit: context: message above was deleted by its author.

@Faez-Ansari
Copy link

Faez-Ansari commented Nov 11, 2023

When I use fullscreen 0, it fullscreens and send fullscreen signal to browser. If I set it to one it doesn't fullscreen anymore

Edit: it does back it doesn't fill up the screen just removes the other windows

@LucStr
Copy link

LucStr commented Nov 15, 2023

Hello everyone. I've been having the exact same issue as described in here. For my workflow I like to work with fullscreen, but some applications mainly chromium think it's a good idea to just go into presentation mode upon being prompted to go to fullscreen mode. Additionally jetbrains IDEs also encountered an issue where it automatically leaves fullscreen if you go fullscreen https://youtrack.jetbrains.com/issue/IDEA-330605/IntelliJ-automatically-leaving-full-screen-in-tiling-WM

I am not a c++ developer by any means, but I tried my best in debugging my issue and getting a workaround for it. It is actually fairly simple in my case 4afae34 This will completely remove the functionality of using the applications native fullscreen mode. For my usecase this is fine, at least so far. I might encounter issues down the line.

@vaxerski I am not sure if I would be able to get this into a state where it would be worth to get merged, but from an implementation perspective I would assume I would create a new value in eFullscreenMode and replace all the references of where FULLSCREEN_FULL is used with || operators to encompass a new mode?

To get nixos to properly apply the patch I've used this LucStr/nix-config@c8748a3 (I am new to nixos so this was a bit of a struggle for me and might not be best practice)

vaxerski pushed a commit that referenced this issue Feb 17, 2024
…#4720)

* Add extra option to fullscreen

* Remove useless branch

fixes #1817

---------

Co-authored-by: matteo bob <matteo4375@gmail.com>
fufexan pushed a commit to fufexan/Hyprland that referenced this issue Feb 23, 2024
…hyprwm#4720)

* Add extra option to fullscreen

* Remove useless branch

fixes hyprwm#1817

---------

Co-authored-by: matteo bob <matteo4375@gmail.com>
lisuke pushed a commit to lisuke/Hyprland that referenced this issue Apr 15, 2024
…hyprwm#4720)

* Add extra option to fullscreen

* Remove useless branch

fixes hyprwm#1817

---------

Co-authored-by: matteo bob <matteo4375@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants