Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix CI: split inputs and wlroots updating #2645

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Nix CI: split inputs and wlroots updating #2645

merged 1 commit into from
Jul 5, 2023

Conversation

fufexan
Copy link
Member

@fufexan fufexan commented Jul 4, 2023

Describe your PR, what does it fix/add?

Now there are separate update scripts for wlroots and for all other
inputs.
nix/update-inputs.sh will check daily for new versions of mesa in Nixpkgs and update the inputs if a newer one is found.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

From the limited testing I've done, it seems to work.

Is it ready for merging, or does it need work?

Ready, just need a few more eyes approving it.
@n3oney @NotAShelf @FlafyDev

Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FlafyDev FlafyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good except for one thing. I'm not sure how to test github actions, though..

Also, should the hyprland-protocols input be updated from its submodule as well?

nix/update-wlroots.sh Outdated Show resolved Hide resolved
Now there are separate update scripts for wlroots and for all other
inputs.
@fufexan
Copy link
Member Author

fufexan commented Jul 5, 2023

Also, should the hyprland-protocols input be updated from its submodule as well?

I don't see why not. Vaxry probably updates it as soon as he adds a change anyway.

@fufexan
Copy link
Member Author

fufexan commented Jul 5, 2023

Alright, if it's all good I'll merge.

@fufexan fufexan merged commit 981c71e into main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants