Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe direction lock #3052

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Swipe direction lock #3052

merged 7 commits into from
Aug 23, 2023

Conversation

end-4
Copy link
Contributor

@end-4 end-4 commented Aug 22, 2023

Describe your PR, what does it fix/add?

  • Adds the config option gestures:workspace_swipe_direction_lock, which forces the destination to be in one direction only once the user starts swiping.
    • True by default
    • Let's say the user wants to switch to workspace on the right. They swipe halfway and change their mind and swipe back to cancel that. Setting this to true prevents over-swiping to the workspace on the left.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

  • Since the option is true by default, it introduces a change in default behavior. But I guess it makes sense (Windows is like that).

Is it ready for merging, or does it need work?

  • Ready

src/managers/input/Swipe.cpp Outdated Show resolved Hide resolved
src/managers/input/Swipe.cpp Outdated Show resolved Hide resolved
@end-4
Copy link
Contributor Author

end-4 commented Aug 23, 2023

Done
I have thought about threshold but there's already some kind of threshold for me. Guess that was a hardware-specific thing.
Now, is 10px enough for fingers of an average linux user, however fat they might be?

@vaxerski
Copy link
Member

unless someone is as fat as nicocado avocado then it should be enough, and in the case they are, we recommend the gym and not hyprland, so this should be enough

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top g

@vaxerski vaxerski merged commit 17ea7db into hyprwm:main Aug 23, 2023
8 checks passed
@end-4 end-4 deleted the swipe-direction-lock branch August 23, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants