Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Hyprland box implementation #3755

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Internal: Hyprland box implementation #3755

merged 3 commits into from
Nov 4, 2023

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Nov 4, 2023

Cleans up some stuff, implements Hyprland boxes.

Fixes: #2402 #3511

Chonker

@vaxerski vaxerski requested a review from fufexan November 4, 2023 15:18
@RoootTheFox
Copy link

image
Hyprland doesn't seem to respect waybar's exclusive setting (windows do go behind waybar which they didn't do previously)

@vaxerski
Copy link
Member Author

vaxerski commented Nov 4, 2023

oops, fixed

@RoootTheFox
Copy link

another thing i noticed: it seems to render new shadows behind windows now, not sure if this is related to this MR or if that's because i just haven't updated Hyprland before in a while

before:
image
after:
image

wanted to mention this anyway

the MR looks perfectly fine otherwise though, those are the only things i noticed

@vaxerski
Copy link
Member Author

vaxerski commented Nov 4, 2023

wdym, they have always been behind.

Only thing that changed is that today morning a patch was merged that draws shadows around decorations, so it doesn't render them under borders now.

@TheK0tYaRa
Copy link

image
There seems to be a scaling issue in kotatogram fullscreen view with this one.

@Vagahbond
Copy link
Contributor

Weiiiiird things happening when I open a foot terminal (not with other apps that I tried).

It opens tiny

then when I move it it's resized to expected size.
Got:
1699115018_grim

Expected:
1699115028_grim

@vaxerski
Copy link
Member Author

vaxerski commented Nov 4, 2023

aren't those also present on -git? #3754

@Vagahbond
Copy link
Contributor

Yes, also present on this:

❯ hyprctl version 
Hyprland, built from branch  at commit 73e78f05ad5cafa20ac5bf177c94ac9ecca37097  ().
Tag: 

flags: (if any)
debug

@vaxerski
Copy link
Member Author

vaxerski commented Nov 4, 2023

so it's unrelated to this mr

@matt1432
Copy link
Contributor

matt1432 commented Nov 4, 2023

This branch does fix #3754

It doesn't let me build Hyprgrass though, gives me errors like this error: 'bottomRight' was not declared in this scope

@matt1432
Copy link
Contributor

matt1432 commented Nov 4, 2023

Also my cursor sometimes stays when I use my touchscreen

@vaxerski
Copy link
Member Author

vaxerski commented Nov 4, 2023

I'll merge this because all of yalls issues are unrelated

@vaxerski vaxerski merged commit 55b4f84 into main Nov 4, 2023
20 checks passed
thejch pushed a commit to thejch/Hyprland that referenced this pull request Nov 15, 2023
* box impl

* remove unused operators

* missed applyfromwlr
@vaxerski vaxerski deleted the hyprland-boxes branch August 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 pixel gaps on no-gap settings
5 participants