-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: apply clang-format #4039
Conversation
I'd rather not, the problem is that my PC for some reason has a wonky clang-format. the |
Your PC not following the configuration is weird. The Lines 60 to 61 in 37d7a8c
Can you check which parameter is set on your PC by running There is multiple way to check and fix clang-format error, I personally use meson with this command : |
Console sideOk, does running VScode sideI guess your are using this extension : xaver.clang-format. I tried it on my instance, and with default settings it work as expected. Maybe there is an extension parameter leading to your wonky formatting. Can your check if you have any modified extension settings on your VSCodium ? For that :
|
Great that you found out how to make it work I just rebased my branch on main, re-run clang-format and created a separe ci job. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks!
Describe your PR, what does it fix/add?
This commit apply clang-format styling to all files.
I also added a check in CI for clang-format, to prevent future commit from having clang-format styling error.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This commit changes quite a few lines of codes, it might break some pending PR.
I only added the check in one of the three existing build job. I can add it to the other two for more homogeneity between jobs, or create a dedicated job.
Is it ready for merging, or does it need work?
Apart from the point raised above, it is ready for merging