Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspacerules: add back on-created-empty functionality #5452

Merged
merged 5 commits into from
Apr 6, 2024

Conversation

alyanser
Copy link
Contributor

@alyanser alyanser commented Apr 6, 2024

Describe your PR, what does it fix/add?

on-created-empty stopped working after 094bce8. i guess the m_bOnCreatedEmptyExecuted check was mistakenly removed while simplying the function.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

no

Is it ready for merging, or does it need work?

ready to merge

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better question is why is it even here and not in the constructor of CWorkspace?

@alyanser
Copy link
Contributor Author

alyanser commented Apr 6, 2024

moved it to CWorkspace::init.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 1596e2d into hyprwm:main Apr 6, 2024
9 checks passed
lisuke pushed a commit to lisuke/Hyprland that referenced this pull request Apr 15, 2024
* workspacerules: add back on-created-empty functionality

* clang format

* workspacerules: spawn on-created-empty window while initializing CWorkspace

* clang format

* configManager: fix typo

---------

Co-authored-by: Your Name <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants