Clean environment when exiting

[ikalco]

Describe your PR, what does it fix/add?

fixes
hyprland doesn't clean up its Wayland sockets after exit #4226

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Whether we should unlink the wayland sockets is debatable.
Technically wl_display_destroy() should be called to clean up everything wayland.

This function emits the wl_display destroy signal, releases all the sockets added to this display, free's all the globals associated with this display, free's memory of additional shared memory formats and destroy the display object.

I'm not sure why we don't (maybe wlroots manages this?), but when I tried it stalls Hyprland shutdown and just doesn't end up removing the sockets...

Is it ready for merging, or does it need work?

CCompositor::cleanEnvironment works as expected on my system
but also see above

[vaxerski]

rest lgtm, why draft?

[ikalco]

should be good to go formatting, now should be good

[vaxerski]

lgtm

[ikalco]

uuuuuh, I accidentally removed this from commit ;-;

diff --git a/src/Compositor.cpp b/src/Compositor.cpp
index 11834043..ac8b11f0 100644
--- a/src/Compositor.cpp
+++ b/src/Compositor.cpp
@@ -451,6 +451,10 @@ void CCompositor::cleanup() {
 
     wl_display_terminate(m_sWLDisplay);
     m_sWLDisplay = nullptr;
+
+    std::string waylandSocket = std::string{getenv("XDG_RUNTIME_DIR")} + "/" + m_szWLDisplaySocket;
+    std::filesystem::remove(waylandSocket);
+    std::filesystem::remove(waylandSocket + ".lock");
 }
 
 void CCompositor::initManagers(eManagersInitStage stage) {

[vaxerski]

feel free to open a new mr