compositor: fix getMonitorFromVector returning wrong monitor #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungyoonc
changed the title
vaxerski
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #5977
Related #5973 (This fixes my issues with firefox, but not sure if the OP's issue is same as mine)
When the second monitor is placed right next to the main monitor,
getMonitorFromVector()will return the main monitor when it is supplied with the pos of the top left corner of the second monitor.For example,
main monitor pos: 0x0, size: 1920x1080
second monitor pos:1920x0, size 1920x1080
In this case when you try to get the monitor with a vector (1920, 0)(e.g. fullscreened firefox, layershell anchored to top left), it will get the main monitor instead of the second monitor.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I don't know if changing the VECINRECT macro like this would break other parts of the code that uses this macro.
Is it ready for merging, or does it need work?
Ready if this change isn't a wrong approach