use add_custom_command for generating protocols #6104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fufexan
force-pushed
the
cmake-proper-rebuild-2
branch
from
56b7d47
to
d83b83c
Compare
This fixes an issue with build error in case of e.g.
$ rm protocols/*.{c,h}
$ cmake --build build
The workaround was to touch CMakeLists.txt. With this PR, protocol files
are properly regenerated with no extra efforts.
Also, resolve hyprwayland-scanner dependency via cmake instead
ofpkg-config.
fufexan
force-pushed
the
cmake-proper-rebuild-2
branch
from
d83b83c
to
399f4d3
Compare
fufexan
added a commit
that referenced
this pull request
May 21, 2024
The-Briel-Deal
pushed a commit
to The-Briel-Deal/Hyprland
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is v2 of this PR, I made a new one to keep git history clean)
This fixes an issue with build error in case of e.g.
$ rm protocols/*.h $ cmake --build buildThe workaround was to
With this PR, protocol files are properly regenerated with no extra efforts.
Also, resolve hyprwayland-scanner dependency via cmake instead of pkg-config.