Expose pseudotiled state in hyprctl clients and add an optional window argument for the pseudo dispatcher #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Przegryw321
changed the title
vaxerski
previously approved these changes
Jun 18, 2024
|
done |
vaxerski
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
As I mentioned in #6550 I wanted to be able to get the information about the pseudotiled state of a window in
hyprctl clientsand the ability to provide a window as an optional argument for thepseudodispatcher. This PR does exactly that. This does not break any compatibility as thepseudodispatcher can still use the active window if no argument or the wordactiveis passed. I based the code on thetoggleActiveFloatingCorefunction.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No.
Is it ready for merging, or does it need work?
I think it's good.