Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bordercolor windowrule #992

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Add bordercolor windowrule #992

merged 3 commits into from
Nov 13, 2022

Conversation

ElJeffe
Copy link
Contributor

@ElJeffe ElJeffe commented Nov 11, 2022

Describe your PR, what does it fix/add?

#880 Add a windowrule to change the bordercolor of the window. This overrides the active bordercolor OR the active bordercolor and inactive bordercolor.
i.e.
windowrulev2 = bordercolor rgb(EE4B55) rgb(880808),class:^(blueman-manager)$
windowrulev2 = bordercolor rgb(EE4B2B),class:^(foot)$

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

@vaxerski
Copy link
Member

I hope you tested this.

LGTM.

Make a wiki PR and I'll merge this.

@ElJeffe
Copy link
Contributor Author

ElJeffe commented Nov 13, 2022

Yes, I tested it, it works here.
hyprwm/hyprland-wiki#51

@vaxerski vaxerski merged commit 549fdf6 into hyprwm:main Nov 13, 2022
@ElJeffe ElJeffe deleted the bordercolor_rule branch November 17, 2022 14:39
0xk1f0 added a commit to 0xk1f0/Hyprland that referenced this pull request Nov 25, 2022
0xk1f0 added a commit to 0xk1f0/Hyprland that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants