core: grace unlock improvements and auth fixes for grace/SIGUSR1 unlocks #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaideiaDilemma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423
Grace code previously respected the case when
m_bFadeStartedwas already set, but notm_bTerminatein casegerneral:no_fade_outis used.Auth needs to check for
isUnlockedto not cause a failed authentication attempt. Also we don't need to enqueuepasswordCheckTimerCallbackif we are already unlocked.I didn't like
successbeing part ofm_sConversationState. So I moved it outside of it, used the return value ofauthto set it and renamed it tom_bAuthenticated.b6d2be6 is just in there because i noticed it.