input-field: refactor updateColors and other improvements #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked into the
updateColorcode for the input field because of #468.I did not understand what was going on, so I rewrote the function.
I think it behaves as it did before with all the different options, but now
swap_font_colorandinvert_numlockwork as expected.Notable is that there are no animations for font color changes (which happen when
outline_thickness=0andswap_font_color=1). As reported in #468 those options are currently broken.I implemented animations for the font, but making subsequent requests to the asyncResourceGatherer with changing colors is not nice and lead to some problems. So the
updateColorsfunction just sets the font color without animating it.I did quite a bit of testing but if someone can double check if everything works that would be appreciated.
Closes #468