[DYOD] Team 3 - Sprint 4 #2569
Merged
[DYOD] Team 3 - Sprint 4 #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tarik Alnawa <43680469+T4rikA@users.noreply.github.com> Co-authored-by: Paula <67064988+postmartem@users.noreply.github.com>
SanJSp
force-pushed
the
dyod2023_team3_tests
branch
from
8e3a186
to
a96ca47
Compare
|
I've accepted the invite now 🥳 |
Bouncner
reviewed
Jun 15, 2023
dey4ss
reviewed
Jun 15, 2023
| std::shared_ptr<Table> expected_result = | ||
| load_table("resources/test_data/tbl/int_float_filtered2.tbl", ChunkOffset{2}); | ||
|
|
||
| auto difference = std::make_shared<Difference>(_table_wrapper_a, _table_wrapper_b); |
SanJSp
force-pushed
the
dyod2023_team3_tests
branch
from
7814fa8
to
ceb9ecb
Compare
Bouncner
reviewed
Jun 17, 2023
T4rikA
force-pushed
the
dyod2023_team3_tests
branch
from
4d19f6b
to
90fd2f0
Compare
Bouncner
reviewed
Jun 26, 2023
Bouncner
reviewed
Jun 27, 2023
|
Retriggering CI with empty commit. 
|
dey4ss
reviewed
Jun 30, 2023
dey4ss
approved these changes
Jun 30, 2023
Co-authored-by: Daniel Lindner <27929897+dey4ss@users.noreply.github.com>
dey4ss
reviewed
Jun 30, 2023
nikriek
pushed a commit
that referenced
this pull request
Oct 28, 2023
Add tests for `Difference` operator and the `<<` operator of the `OperatorScanPredicate`. --------- Co-authored-by: Tarik Alnawa <43680469+T4rikA@users.noreply.github.com> Co-authored-by: Paula <67064988+postmartem@users.noreply.github.com> Co-authored-by: Tarik Alnawa <talnawa@outlook.de> Co-authored-by: Bouncner <martin+github@boissier.de> Co-authored-by: Daniel Lindner <27929897+dey4ss@users.noreply.github.com>
nikriek
pushed a commit
that referenced
this pull request
Nov 6, 2023
Add tests for `Difference` operator and the `<<` operator of the `OperatorScanPredicate`. --------- Co-authored-by: Tarik Alnawa <43680469+T4rikA@users.noreply.github.com> Co-authored-by: Paula <67064988+postmartem@users.noreply.github.com> Co-authored-by: Tarik Alnawa <talnawa@outlook.de> Co-authored-by: Bouncner <martin+github@boissier.de> Co-authored-by: Daniel Lindner <27929897+dey4ss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first tried to add coverage to
TableColumnDefinition, but foundconcatenatedas unsused an also not working function. Hence we removed it to increase coverage this way.Next we added a simple test for the
Differenceoperator'sgetName()function.Last we added a varying test for the
<<operator of theOperatorScanPredicate